On 28.10.2016 08:55, Laine Stump wrote: > (From the "How the Hell did I not see this?" files) > > commit 9065cfaa added the ability to disable DNS services for a > libvirt virtual network. If neither DNS nor DHCP is needed for a > network, then we don't need to start dnsmasq, so code was added to > check for this. > > Unfortunately, it was written with a great lack of attention to detail > (I can say that, because I was the author), and the loop that checked > if DHCP is needed for the network would never end if the network had > multiple IP addresses, and none of them had a <dhcp> section (which > would have contained a <range> or <host> element). > > This patch rewrites the check to be more compact and (more > importantly) finite. > > This bug was present in release 2.2.0 and 2.3.0, so will need to be > backported to any relevant maintainence branches. > > Reported here: > https://www.redhat.com/archives/libvirt-users/2016-October/msg00032.html > https://www.redhat.com/archives/libvirt-users/2016-October/msg00045.html > --- > src/network/bridge_driver.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) ACK Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list