On Wed, 2016-10-19 at 15:58 +0100, Daniel P. Berrange wrote:
> On Wed, Oct 19, 2016 at 04:51:27PM +0200, Andrea Bolognani wrote:
> >
> > We only claim support for OSs that are still supported by the
> > respective vendors, which means anything older than Fedora 23
> > is out. Reword the comment a bit to highlight the criteria.
> > ---
> > libvirt.spec.in | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/libvirt.spec.in b/libvirt.spec.in
> > index 00b95b8..25dc31d 100644
> > --- a/libvirt.spec.in
> > +++ b/libvirt.spec.in
> > @@ -1,9 +1,10 @@
> > # -*- rpm-spec -*-
> >
> > -# This spec file assumes you are building for Fedora 20 or newer,
> > -# or for RHEL 6 or newer. It may need some tweaks for other distros.
> > +# This spec file assumes you are building on a Fedora or RHEL version
> > +# that's still supported by the vendor: that means Fedora 23 or newer,
> > +# or RHEL 6 or newer. It may need some tweaks for other distros.
> > # If neither fedora nor rhel was defined, try to guess them from dist
> > -%if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6)
> > +%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6)
>
> If you change this version, you should be updating/removing conditional
> checks in the file which use versions < 23
Right you are. v2 coming in a minute :)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
