On Mon, Oct 03, 2016 at 04:49:48PM +0100, Daniel P. Berrange wrote: > Currently if you want to enable UEFI firmware for a guest > you need to know about the hypervisor platform specific > firmware path. This does not even work for all platforms, > as hypervisors like VMWare don't expose UEFI as a path, > they just have a direct config option for turning it on > or off. > > This adds ability to use the much simpler: > > <loader firmware="uefi|bios"/> > > to choose the different firmware types. Although not in the scope of this patch, virt-v2v would really like the ESX driver in libvirt to return this data for existing guests. I believe there is an open RFE about that somewhere. Patches 2 & 3 look fine to me, ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list