On Fri, 2016-10-14 at 15:54 -0400, Laine Stump wrote:
> An upcoming commit will remove the "flag" argument from all the calls
> to reserve the next available address|slot, but I don't want to change
> the arguments in the hypervisor-agnostic
> virDomainPCIAddressReserveNext*() functions, so this patch places a
> simple qemu-specific wrapper around those functions - the new
> functions don't take a flags arg, but grab it from the device's
> info->pciConnectFlags.
> ---
> Change: realigned/reformatted
>
> src/qemu/qemu_domain_address.c | 96 ++++++++++++++++++++++++++----------------
> 1 file changed, 59 insertions(+), 37 deletions(-)
[...]
> @@ -691,7 +712,7 @@ qemuDomainValidateDevicePCISlotsPIIX3(virDomainDefPtr def,
>
> if (virDomainPCIAddressSlotInUse(addrs, &tmp_addr)) {
> if (qemuDeviceVideoUsable) {
> - if (virDomainPCIAddressReserveNextSlot(addrs,
> + if (qemuDomainPCIAddressReserveNextSlot(addrs,
> &primaryVideo->info,
> flags) < 0)
Alignment's still off here.
ACK with that fixed.
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list