On 10/07/2016 12:43 PM, Jiri Denemark wrote:
> GCC on s390 complains
>
> util/virconf.c: In function 'virConfGetValueSizeT':
> util/virconf.c:1220:9: error: format '%zu' expects argument of type
> 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=]
>
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
> src/util/virconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/util/virconf.c b/src/util/virconf.c
> index 3e49f41..1372389 100644
> --- a/src/util/virconf.c
> +++ b/src/util/virconf.c
> @@ -1219,7 +1219,7 @@ int virConfGetValueSizeT(virConfPtr conf,
> if (((unsigned long long)cval->l) > SIZE_MAX) {
> virReportError(VIR_ERR_INTERNAL_ERROR,
> _("%s: value for '%s' parameter must be in range 0:%zu"),
> - conf->filename, setting, SIZE_MAX);
> + conf->filename, setting, (size_t) SIZE_MAX);
> return -1;
> }
> #endif
I've just noticed that a colleague fixed that already quite some time ago in Glibc. So please update:
commit 26011b5cfa6a1a8d8005d65f11d97498444a4e95
Author: Stefan Liebler <stli@xxxxxxxxxxxxxxxxxx>
Date: Mon Mar 24 16:46:51 2014 +0100
S390: Define SIZE_MAX as unsigned long (BZ #16712).
diff --git a/ChangeLog b/ChangeLog
index 4da1027..c0d13ab 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
2014-03-24 Stefan Liebler <stli@xxxxxxxxxxxxxxxxxx>
+ [BZ #16712]
+ * sysdeps/s390/s390-32/bits/wordsize.h
+ (__WORDSIZE32_SIZE_ULONG): New define.
+ * sysdeps/s390/s390-64/bits/wordsize.h
+ (__WORDSIZE32_SIZE_ULONG): Likewise.
+ * sysdeps/generic/stdint.h (SIZE_MAX):
+ Define as UL if __WORDSIZE32_SIZE_ULONG.
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list