On 10/06/2016 09:38 AM, Michal Privoznik wrote: > Instead of blindly claim support for hot-plugging of every > interface type out there we should copy approach we have for > device types: white listing supported types and explicitly error > out on unsupported ones. > For instance, trying to hotplug vhostuser interface results in > nothing usable from guest currently. vhostuser typed interfaces > require additional work on our side. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_hotplug.c | 33 +++++++++++++++++++++++++++------ > 1 file changed, 27 insertions(+), 6 deletions(-) > Should have just kept quiet in the v1 review about a switch ;-) FWIW: If someone tries to add a vhostuser it will fail before the unsupported message because the "if (net->driver.virtio.queues > 0 && ..." doesn't have VHOSTUSER in the list like it does for command line. I'm OK with adding that in here now or as a separate patch... ACK for what's here. John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list