On Wed, Oct 12, 2016 at 02:12:58PM +0200, Pavel Hrdina wrote:
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1369633 Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> --- Changes in v2: - added bugzilla into commit message docs/formatdomain.html.in | 3 +- src/qemu/qemu_domain.c | 3 +- .../qemuxml2argv-video-virtio-gpu-sec.args | 22 ++++++++++++++ .../qemuxml2argv-video-virtio-gpu-sec.xml | 27 +++++++++++++++++ tests/qemuxml2argvtest.c | 3 ++ .../qemuxml2xmlout-video-virtio-gpu-sec.xml | 35 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 7 files changed, 92 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-sec.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-sec.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-sec.xml
'sec' is too ambiguous for my taste, can you spell it out fully?
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index b989c8f..14e0f48 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -5641,7 +5641,8 @@ qemu-kvm -net nic,model=? /dev/null
video device in domain xml is the primary one, but the optional
attribute <code>primary</code> (<span class="since">since 1.0.2</span>)
with value 'yes' can be used to mark the primary in cases of multiple
- video device. The non-primary must be type of "qxl".
+ video device. The non-primary must be type of "qxl" or
+ "virtio" (<span class="since">since 2.4.0</span>).
I would put the (since) between or and "virtio", to make it obvious it does not apply to "qxl". ACK Jan
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list