Re: [PATCH 1/5] Change virDomainEventState to virObjectLockable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11.10.2016 20:53, Martin Kletzander wrote:
> This way we get reference counting and we can get rid of locking
> function.
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  src/bhyve/bhyve_driver.c           |  2 +-
>  src/conf/object_event.c            | 99 +++++++++++++++-----------------------
>  src/conf/object_event.h            |  1 -
>  src/libvirt_private.syms           |  1 -
>  src/libxl/libxl_driver.c           |  2 +-
>  src/lxc/lxc_driver.c               |  2 +-
>  src/network/bridge_driver.c        |  2 +-
>  src/node_device/node_device_udev.c |  2 +-
>  src/qemu/qemu_driver.c             |  2 +-
>  src/remote/remote_driver.c         |  2 +-
>  src/storage/storage_driver.c       |  2 +-
>  src/test/test_driver.c             |  2 +-
>  src/uml/uml_driver.c               |  2 +-
>  src/vbox/vbox_common.c             |  2 +-
>  src/vz/vz_driver.c                 |  2 +-
>  src/xen/xen_driver.c               |  2 +-
>  16 files changed, 52 insertions(+), 75 deletions(-)
> 


> diff --git a/src/conf/object_event.h b/src/conf/object_event.h
> index b0201ddd5a12..7a9995e122e7 100644
> --- a/src/conf/object_event.h
> +++ b/src/conf/object_event.h
> @@ -40,7 +40,6 @@ typedef struct _virObjectEventState virObjectEventState;
>  typedef virObjectEventState *virObjectEventStatePtr;
> 
> 
> -void virObjectEventStateFree(virObjectEventStatePtr state);
>  virObjectEventStatePtr
>  virObjectEventStateNew(void);
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index b88e903744ec..d92d3d865307 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -818,7 +818,6 @@ virNWFilterVarValueGetSimple;
>  # conf/object_event.h
>  virObjectEventStateDeregisterID;
>  virObjectEventStateEventID;
> -virObjectEventStateFree;
>  virObjectEventStateNew;
>  virObjectEventStateQueue;

Don't forget to remove this function from cfg.mk too.

ACK

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]