Re: [PATCH 6/7] util: Remove need for local 'nelems'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 10, 2016 at 11:42:17 -0400, John Ferlan wrote:
> Since it's only used in loop - just go direct.

Not sure how deep coverity sees stuff, but in some cases this would
increase the complexity of the loop from O(n) to O(n^2) since the
function gets evaluated on every single loop, but the returned value
never changes.

In this case it's okay, since virJSONValueArraySize does not do any
iteration over the list.

> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---

ACK in this case, but we need to be careful.

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]