Re: [PATCH 03/11] qemu_capabilities: mark QEMU_CAPS_VGA_QXL capability as deprecated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/30/2016 12:02 PM, Pavel Hrdina wrote:
> If QEMU in question supports QMP, this capability is set if
> QEMU_CAPS_DEVICE_QXL was set based on existence of "-device qxl". If
> libvirt needs to parse *help*, because there is no QMP support, it
> checks for existence of "-vga qxl", but it also parses output of
> "-device ?" and sets QEMU_CAPS_DEVICE_QXL too.
> 
> Now that libvirt supports only QEMU that has "-device" implemented it's
> safe to drop this capability and stop using it.
> 
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  src/qemu/qemu_capabilities.c                     |  5 -----
>  src/qemu/qemu_capabilities.h                     |  2 +-
>  src/qemu/qemu_command.c                          |  2 +-
>  tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml |  1 -
>  tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml |  1 -
>  tests/qemuhelptest.c                             |  2 --
>  tests/qemuxml2argvtest.c                         | 24 +++---------------------
>  tests/qemuxml2xmltest.c                          | 13 ++++---------
>  17 files changed, 9 insertions(+), 50 deletions(-)
> 

ACK

John

FWIW:
There is one more QEMU_CAPS_VGA_NONE listed on the bite sized tasks
wiki... Could use the opportunity to add a patch for that too...

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]