Re: RFC: Exposing "ready" bool (of `query-block-jobs`) or QMP BLOCK_JOB_READY event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/06/2016 10:06 AM, Kashyap Chamarthy wrote:
> On Thu, Oct 06, 2016 at 09:25:26AM -0500, Eric Blake wrote:
>> On 10/06/2016 06:34 AM, Peter Krempa wrote:
> 
> [...]
> 
>>> We expose the state of the copy job in the XML and forward the READY
>>> event from qemu to the users.
>>
>> I was not aware of that when I was chatting on IRC yesterday; that's
>> useful to know, because virDomainGetBlockJobInfo() is NOT exposing that
>> information at the moment.
> 
> That is what this RFC was asking to consider -- whether an [I think it
> has to be a new one] API should report.

I think we've answered this one - we don't need a new API, because
parsing the domain XML already provides the current 'ready':true/false
status from qemu.

The existing virDomainGetBlockJobInfo() can't be extended, but it can be
fixed to quit reporting cur==end when ready:false.

> 
> Given the above, I've re-opened the bug here:
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=1382165#c3

Thanks.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]