Re: [PATCH] virt-yajl: Fix detection of yajl requirements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-10-06 at 11:32 +0200, Martin Kletzander wrote:
> Running the output of qemu -help doesn't make any sense.  We should be
> looking for libvirt being mentioned in the output.  This worked by
> accident, let's make it work as expected it to.
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  m4/virt-yajl.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/virt-yajl.m4 b/m4/virt-yajl.m4
> index adf2819eeb66..8c452adca653 100644
> --- a/m4/virt-yajl.m4
> +++ b/m4/virt-yajl.m4
> @@ -26,7 +26,7 @@ AC_DEFUN([LIBVIRT_CHECK_YAJL],[
>      AC_PATH_PROGS([QEMU], [qemu-kvm qemu kvm qemu-system-x86_64],
>                    [], [$PATH:/usr/bin:/usr/libexec])
>      if test -x "$QEMU"; then
> -      if `$QEMU -help | grep libvirt` >/dev/null; then
> +      if $QEMU -help 2>/dev/null | grep -q libvirt; then
>          with_yajl=yes
>        else
>          [qemu_version_sed='s/.*ersion \([0-9.,]*\).*/\1/']

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]