Re: [PATCH 00/12] Add length (duration) params for iotune throttling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/27/2016 11:21 AM, Michal Privoznik wrote:
> On 23.09.2016 14:56, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1349898
>>
>> Do a little housekeeping and minor adjustments to existing code, then
>> add the various "-length" options for the <iotune> code.
>>
>>
>> John Ferlan (12):
>>   docs: Fix typo in libvirt-domain.h parameter description
>>   include: Update description for <iotune> max params
>>   tests: Add blkdeviotune-max xml2xmltest
>>   qemu: Convert from shorthand to longer throttling names
>>   qemu: Adjust how supportMaxOptions is used.
>>   include: Add new definitions for duration for bps/iops throttling
>>   caps: Add new capability for the bps/iops throttling length
>>   qemu: Add length for bps/iops throttling parameters to driver
>>   conf: Add a formatting macro for all the blkiotune values
>>   conf: Adjust the PARSE_IOTUNE macro
>>   conf: Add support for blkiotune "_length" options
>>   qemu: Add the length options to the iotune command line

[...]

> 
> ACK series.
> 
> Michal
> 

Thanks -

I pushed patches 1-5 and 9

I'm holding onto patches 6 & 7 until I can get the libvirt-perl
adjustments ready (and libvirt-perl 2.3.0 is bottled up).

I need to adjust patch 8 based on the virsh work - it's not major, just
a "difference" in how the _length parameters can be set compared to how
other values are set.

I dropped patch 10

Once patch 8 is worked out, patches 11 & 12 haven't changed.

And of course, the v2 will have the virsh command adjustments, plus a
patch to qemu_driver.c as has been discussed as 8.5 in this series.

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]