Re: [PATCH] qemu: allow 32 slots on pcie-expander-bus, not just 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/05/2016 12:25 PM, Martin Kletzander wrote:
On Wed, Oct 05, 2016 at 11:34:13AM -0400, Laine Stump wrote:
When I added support for the pcie-expander-bus controller in commit
bc07251f, I incorrectly thought that it only had a single slot
available. Actually it has 32 slots, just like the root complex aka
pcie-root (the part that I *did* get correct is that unlike pcie-root
a pcie-expander-bus doesn't allow any integrated endpoint devices -
only pcie-root-ports and dmi-to-pci-controllers are allowed).
---
src/conf/domain_addr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


ACK, works for me.

Thanks, I pushed it.

But the message when the slot is exceeded (without
your patch, I just wanted to try everything) is really bad:

 error: XML error: Invalid PCI address 0000:03:01.0. slot must be <= 0

Yeah, I guess it's worth a special case when min and max are equal (to 0, in practice)

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]