On Tue, Oct 04, 2016 at 03:57:10PM -0500, Eric Blake wrote: > On 10/04/2016 01:22 PM, Eduardo Habkost wrote: > > On Mon, Oct 03, 2016 at 03:15:39PM -0500, Eric Blake wrote: > > [...] > >>> 3.2) Removing the unimplemented command from query-commands only > >>> (by calling qmp_disable_command()), but keeping it on the QAPI > >>> schema. I am not sure it's OK to do that. If it is, this > >>> sounds like the simplest solution. > >> > >> We already have existing commands in this category, and it is > >> conceptually the easiest (if query-commands doesn't list the command, > >> then the command doesn't work even if the introspection still shows it). > > [...] > > > > Which commands are already in this category? I don't see any > > qmp_disable_command() calls on the tree except for guest agent > > code. > > Probably a typo on my side; commit 5032a16d adds the use of > qmp_unregister_command(), not qmp_disable_command(). Thanks for the pointer. I will try to move the query-cpu-* hack there. -- Eduardo -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list