On 04.10.2016 18:03, Peter Krempa wrote: > On Fri, Sep 30, 2016 at 15:28:08 +0200, Daniel Veillard wrote: >> On Fri, Sep 30, 2016 at 11:37:08AM +0200, Guido Günther wrote: >>> On Tue, Sep 27, 2016 at 10:14:36PM +0200, Daniel Veillard wrote: >>>> Since nobody complained about my earlier message with the release plan, >>>> I tagged libvirt-2.3.0 candidate release 1 in git and pushed signed tarball >>>> and rpms to the usual place: >>>> >>>> ftp://libvirt.org/libvirt/ >>>> >>>> As usual my limited testing is really not sufficient so please give it a try, >>>> I enjoy the view of a completely green https://ci.centos.org/view/libvirt-project/ :-) >>>> but that doesn't test portability to other platforms for example ! >>>> >>>> Then I will try to push rc2 on Thursday, that way the final release can happen >>>> during the week-end or on Monday if all goes well, >>> >>> The rc1 looks good on Debians buildds: >>> >>> https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental >>> >>> Cheers, >> >> Thanks cool ! >> I didn't do rc2 yesterday, will try to push it today, as a result 2.3.0 will likely go >> out Monday evening ot Tuesday, > > https://www.redhat.com/archives/libvir-list/2016-October/msg00074.html > > pointed out a pretty serious regression that we'd fail to start VM > second time if the vcpu count is not fully allocated. > > This was caused by not running the post parse callbacks after copying > the definition, which my code relied upon. > > I think that reverting those patches at this point is a safer option > since the patch pointed out may be incomplete. Agreed. However, we should really make this work. I mean, the idea that the domain def *copy* function also fills in some blanks, or prepares domain definition for something is really just combining two separate steps into one (that's why we ran into the issue I am fixing with those patches in the first place). What we should do is: 1) call virDomainDefCopy() to create live definition 2) call qemuPrepareDef() (or whatever the name is going to be) to fix up passed definition os vCPU hotplug (or just any other functionality) works. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list