This breaks vCPU hotplug, because when starting a domain, we
create a copy of domain definition (which becomes live XML) and
during the post parse callbacks we might adjust some tunings so
that vCPU hotplug is possible.
This reverts commit c0f90799bc7fa4b690ead6a592806378a243873c.
Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
src/conf/domain_conf.c | 6 ------
src/conf/domain_conf.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 920529a..1e65df1 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -4430,9 +4430,6 @@ virDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
{
int ret;
- if (flags & VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE)
- return 0;
-
if (xmlopt->config.devicesPostParseCallback) {
ret = xmlopt->config.devicesPostParseCallback(dev, def, caps, flags,
xmlopt->config.priv,
@@ -4582,9 +4579,6 @@ virDomainDefPostParse(virDomainDefPtr def,
.parseOpaque = parseOpaque,
};
- if (parseFlags & VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE)
- return 0;
-
/* this must be done before the hypervisor-specific callback,
* in case presence of a controller at a specific index is checked
*/
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index fd3ae8e..a70bc21 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2647,8 +2647,6 @@ typedef enum {
VIR_DOMAIN_DEF_PARSE_ABI_UPDATE = 1 << 9,
/* skip definition validation checks meant to be executed on define time only */
VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE = 1 << 10,
- /* skip post parse callback */
- VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE = 1 << 11,
} virDomainDefParseFlags;
typedef enum {
--
2.8.4
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list