Re: [PATCH 0/2] Increase bound limit for virDomainGetBlockIoTune

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04.10.2016 15:22, John Ferlan wrote:
> Related to my onlist (and ACK'd) series for adding 6 new parameters
> for adding length (duration) parameters to/for iotune throttling:
> 
> http://www.redhat.com/archives/libvir-list/2016-September/msg01090.html
> 
> As described in a response to the cover:
> 
> http://www.redhat.com/archives/libvir-list/2016-October/msg00053.html
> 
> for some reason I had a brain cramp and neglected to check the virsh
> blkdeviotune command. These patches could then be applied before the
> other (already ACK'd) series once the current release is out.

Agreed. this is not something that needs fixing in this release.

> 
> In reality they just need to go in some time before patch 8 which adds
> the 6 new parameters to qemuMonitorGetBlockIoThrottle. A followup
> patch to that series will enable setting the new parameters (IOW:
> changes to virsh-domain.c cmdBlkdeviotune().
> 
> John Ferlan (2):
>   remote: Fix erroneous usage of constant
>   remote: Increase bound limit for virDomainGetBlockIoTune
> 
>  src/remote/remote_driver.c   | 4 ++--
>  src/remote/remote_protocol.x | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 

ACK series,

I think that raising the limits has already proven to be safe over the time.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]