Re: [PATCH] libvirt-storage.c:Lines too long, use 80 character columns.

["Daniel P. Berrange" <berrange@xxxxxxxxxx>]

On Wed, Sep 28, 2016 at 12:27:21AM +0530, Nitesh Konkar wrote:
> Signed-off-by: Nitesh Konkar <nitkon12@xxxxxxxxxxxxxxxxxx>
> ---
>  src/libvirt-storage.c | 24 ++++++++++++++++--------
>  1 file changed, 16 insertions(+), 8 deletions(-)
> 
> diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c
> index 48996ba..c4f2a03 100644
> --- a/src/libvirt-storage.c
> +++ b/src/libvirt-storage.c
> @@ -233,7 +233,8 @@ virConnectNumOfDefinedStoragePools(virConnectPtr conn)
>  
>      virCheckConnectReturn(conn, -1);
>  
> -    if (conn->storageDriver && conn->storageDriver->connectNumOfDefinedStoragePools) {
> +    if (conn->storageDriver &&
> +        conn->storageDriver->connectNumOfDefinedStoragePools) {
>          int ret;
>          ret = conn->storageDriver->connectNumOfDefinedStoragePools(conn);
>          if (ret < 0)
> @@ -280,7 +281,8 @@ virConnectListDefinedStoragePools(virConnectPtr conn,
>      virCheckNonNullArgGoto(names, error);
>      virCheckNonNegativeArgGoto(maxnames, error);
>  
> -    if (conn->storageDriver && conn->storageDriver->connectListDefinedStoragePools) {
> +    if (conn->storageDriver &&
> +        conn->storageDriver->connectListDefinedStoragePools) {
>          int ret;
>          ret = conn->storageDriver->connectListDefinedStoragePools(conn, names, maxnames);
>          if (ret < 0)
> @@ -332,7 +334,8 @@ virConnectFindStoragePoolSources(virConnectPtr conn,
>      virCheckNonNullArgGoto(type, error);
>      virCheckReadOnlyGoto(conn->flags, error);
>  
> -    if (conn->storageDriver && conn->storageDriver->connectFindStoragePoolSources) {
> +    if (conn->storageDriver &&
> +        conn->storageDriver->connectFindStoragePoolSources) {
>          char *ret;
>          ret = conn->storageDriver->connectFindStoragePoolSources(conn, type, srcSpec, flags);
>          if (!ret)
> @@ -485,7 +488,8 @@ virStoragePoolLookupByVolume(virStorageVolPtr vol)
>  
>      virCheckStorageVolReturn(vol, NULL);
>  
> -    if (vol->conn->storageDriver && vol->conn->storageDriver->storagePoolLookupByVolume) {
> +    if (vol->conn->storageDriver &&
> +        vol->conn->storageDriver->storagePoolLookupByVolume) {
>          virStoragePoolPtr ret;
>          ret = vol->conn->storageDriver->storagePoolLookupByVolume(vol);
>          if (!ret)
> @@ -1188,7 +1192,8 @@ virStoragePoolNumOfVolumes(virStoragePoolPtr pool)
>  
>      virCheckStoragePoolReturn(pool, -1);
>  
> -    if (pool->conn->storageDriver && pool->conn->storageDriver->storagePoolNumOfVolumes) {
> +    if (pool->conn->storageDriver &&
> +        pool->conn->storageDriver->storagePoolNumOfVolumes) {
>          int ret;
>          ret = pool->conn->storageDriver->storagePoolNumOfVolumes(pool);
>          if (ret < 0)
> @@ -1230,7 +1235,8 @@ virStoragePoolListVolumes(virStoragePoolPtr pool,
>      virCheckNonNullArgGoto(names, error);
>      virCheckNonNegativeArgGoto(maxnames, error);
>  
> -    if (pool->conn->storageDriver && pool->conn->storageDriver->storagePoolListVolumes) {
> +    if (pool->conn->storageDriver &&
> +        pool->conn->storageDriver->storagePoolListVolumes) {
>          int ret;
>          ret = pool->conn->storageDriver->storagePoolListVolumes(pool, names, maxnames);
>          if (ret < 0)
> @@ -1297,7 +1303,8 @@ virStorageVolLookupByName(virStoragePoolPtr pool,
>      virCheckStoragePoolReturn(pool, NULL);
>      virCheckNonNullArgGoto(name, error);
>  
> -    if (pool->conn->storageDriver && pool->conn->storageDriver->storageVolLookupByName) {
> +    if (pool->conn->storageDriver &&
> +        pool->conn->storageDriver->storageVolLookupByName) {
>          virStorageVolPtr ret;
>          ret = pool->conn->storageDriver->storageVolLookupByName(pool, name);
>          if (!ret)
> @@ -1471,7 +1478,8 @@ virStorageVolCreateXML(virStoragePoolPtr pool,
>      virCheckNonNullArgGoto(xmlDesc, error);
>      virCheckReadOnlyGoto(pool->conn->flags, error);
>  
> -    if (pool->conn->storageDriver && pool->conn->storageDriver->storageVolCreateXML) {
> +    if (pool->conn->storageDriver &&
> +        pool->conn->storageDriver->storageVolCreateXML) {
>          virStorageVolPtr ret;
>          ret = pool->conn->storageDriver->storageVolCreateXML(pool, xmlDesc, flags);
>          if (!ret)

NACK this kind of change is just pointless. Further you've only line
wrapped half of the long lines in this patch context.  We do *not* apply
a strict 80 character limit in libvirt.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list