Re: [PATCH] Fix coding style issues.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/26/2016 03:01 PM, Nitesh Konkar wrote:
> Signed-off-by: Nitesh Konkar <nitkon12@xxxxxxxxxxxxxxxxxx>
> ---
>  src/uml/uml_conf.h          | 2 +-
>  src/vbox/vbox_common.h      | 2 +-
>  tests/qemumonitorjsontest.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 

ACK and pushed w/ one slight adjustment below

Tks -

John

> diff --git a/src/uml/uml_conf.h b/src/uml/uml_conf.h
> index 9a45d10..5da55e5 100644
> --- a/src/uml/uml_conf.h
> +++ b/src/uml/uml_conf.h
> @@ -35,7 +35,7 @@
>  # include "vircommand.h"
>  # include "virhash.h"
>  
> -# define umlDebug(fmt, ...) do {} while(0)
> +# define umlDebug(fmt, ...) do {} while (0)
>  
>  # define UML_CPUMASK_LEN CPU_SETSIZE
>  
> diff --git a/src/vbox/vbox_common.h b/src/vbox/vbox_common.h
> index c8787c3..b178878 100644
> --- a/src/vbox/vbox_common.h
> +++ b/src/vbox/vbox_common.h
> @@ -435,6 +435,6 @@ typedef nsISupports IKeyboard;
>          } else {                                                        \
>              result = -1;                                                \
>          }                                                               \
> -    } while(0)
> +    } while (0)
>  
>  #endif /* VBOX_COMMON_H */
> diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
> index cbc39c6..9823a9d 100644
> --- a/tests/qemumonitorjsontest.c
> +++ b/tests/qemumonitorjsontest.c
> @@ -721,7 +721,7 @@ testQemuMonitorJSONAttachChardev(const void *data)
>          goto cleanup;                                               \
>      if (qemuMonitorAttachCharDev(qemuMonitorTestGetMonitor(test),   \
>                                       chrID, &chr) < 0)              \
> -        ret = fail ? ret  : -1;                                     \
> +        ret = fail ? ret : -1;                                     \

When you delete a space in the line you need to ensure the \ lines up at
the end of the line too...


>      else                                                            \
>          ret = fail ? -1 : ret;                                      \
>  
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]