Re: [PATCH v2 01/11] virDomainDefPostParse: Introduce @parseOpaque argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 23, 2016 at 15:24:54 +0200, Michal Privoznik wrote:
> Some callers might want to pass yet another pointer to opaque
> data to post parse callbacks. The driver generic one is not
> enough because two threads executing post parse callback might
> want see different data (e.g. domain object pointer that domain

s/want see/want to see/

> def belongs to).
> 
...
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index ce90c27..c61b364 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -2361,11 +2361,15 @@ typedef struct _virDomainXMLOption virDomainXMLOption;
>  typedef virDomainXMLOption *virDomainXMLOptionPtr;
>  
>  /* Called once after everything else has been parsed, for adjusting
> - * overall domain defaults.  */
> + * overall domain defaults.
> + * @parseOpaque is opaque data passed by virDomainDefParse* caller,
> + * @opqaue is opaque data set by driver (usually pointer to driver

s/opqaue/opaque/ :)

...

ACK

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]