At 2016-09-22 19:05:33, "John Ferlan" <jferlan@xxxxxxxxxx> wrote:
>
>>>
>>> BTW: Patch 2 fails syntax-check
>>>
>>
>> I make syntax-check again and passed on a centos7 machine.
>> Maybe it's a syntax-check bug?
>>
>
>Don't think so...
>
>
>cppi: src/qemu/qemu_driver.c: line 3269: not properly indented
>maint.mk: incorrect preprocessor indentation
>cfg.mk:680: recipe for target 'sc_preprocessor_indentation' failed
>make: *** [sc_preprocessor_indentation] Error 1
>make: *** Waiting for unfinished jobs....
I didn't install cppi on that centos7 machine.
Sorry for the noise.
>
>Line 3269:
>
>
># define VIR_QEMU_COMPRESS_CHECK(val, type)
> \
> do {
> \
> if (cfg->val) {
>
>...
>
>If the "# define" is changed to "#define", then the syntax-check passes.
>The usage of "# define" is done/allowed with an "#if" or "#ifdef" type
>construct in order to 'mark' that we're within some sort of preprocessor
>condition.
>
>Additionally those lines are too long - use 80 character columns
I need to re-read HACKING :)
Thanks for your help.
Regards,
- Chen
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list