Re: [PATCH 0/7] Pass the path of compress program (redo)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At 2016-09-22 05:30:48, "John Ferlan" <jferlan@xxxxxxxxxx> wrote:
>Rather than try to describe what I was thinking about for the passing
>the compress program directly series from Chen Hanxiao:
>
>http://www.redhat.com/archives/libvir-list/2016-September/msg00677.html
>
>and
>
>http://www.redhat.com/archives/libvir-list/2016-August/msg01237.html
>
>I took the liberty of creating my own set of patches which should end
>in the more or less same result.
>
>The primary benefit is not calling virFileInPath twice since we already
>get it at least once for the various compressed program callers, let's
>pass what we originally found.
>
>John Ferlan (7):
>  qemu: Move getCompressionType
>  qemu: Adjust doCoreDump to call getCompressionType
>  qemu: Introduce helper qemuGetCompressionProgram
>  qemu: Remove getCompressionType
>  qemu: Use qemuGetCompressionProgram for error paths
>  qemu: Remove qemuCompressProgramAvailable
>  qemu: Get/return compressedpath program
>
> src/qemu/qemu_driver.c | 235 +++++++++++++++++++++++--------------------------
> 1 file changed, 111 insertions(+), 124 deletions(-)
>
>-- 

Hi, John

Looks that Patch 1, 3 and 4 should be scrash into one :).
Some other inline comments, Please check.

Regards,
- Chen

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]