Re: [PATCH] qemuDomainOpenGraphics: Start job early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20.09.2016 15:33, Jiri Denemark wrote:
> Checking if a domain's definition or if it is active before we got a job
> is pointless since the domain might have changed in the meantime.
> 
> Luckily libvirtd didn't crash when the API tried to talk to an inactive
> domain:
> 
> debug : qemuDomainObjBeginJobInternal:2914 : Started job: modify
>     (async=none vm=0x7f8f340140c0 name=ble)
> debug : qemuDomainObjEnterMonitorInternal:3137 : Entering monitor
>     (mon=(nil) vm=0x7f8f340140c0 name=ble)
> warning : virObjectLock:319 : Object (nil) ((unknown)) is not a
>     virObjectLockable instance
> debug : qemuMonitorOpenGraphics:3505 : protocol=spice fd=27
>     fdname=graphicsfd skipauth=1
> error : qemuMonitorOpenGraphics:3508 : invalid argument: monitor must
>     not be NULL
> debug : qemuDomainObjExitMonitorInternal:3160 : Exited monitor
>     (mon=(nil) vm=0x7f8f340140c0 name=ble)
> debug : qemuDomainObjEndJob:3068 : Stopping job: modify (async=none
>     vm=0x7f8f340140c0 name=ble)
> 
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

ACK

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]