Re: [PATCH] tests: fix use of fixedcontent variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/19/2016 12:50 PM, Laine Stump wrote:
> Commit 8563560026d192c2cf047b550ffd468692245ed6 switched from
> hardcoded use of strcontent to hardcoded use of fixedcontent
> (fixedcontent is *sometimes* a copy of strcontent with a \n
> appended). This was a problem because sometimes fixedcontent is *not*
> a copy of strcontent, but is instead NULL, leading to the regenerated
> test case output being a 0 length file.
> 
> This patch creates a new const char *cmpcontent initialized to
> strcontent, but changed to fixedcontent if/when fixedcontent is
> created, then always uses cmpcontent instead of (str|fixed)content.
> ---
>  tests/testutils.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

ACK


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]