Re: [PATCH 2/2] libxl: set shadow memory for any guest type, not only HVM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/05/2016 12:05 PM, Marek Marczykowski-Górecki wrote:
> Otherwise starting PVH guest will result in "arch_setup_bootlate:
> mapping shared_info failed (pfn=..., rc=-1, errno: 12): Internal error".
>
> After this change the behaviour is the same as in `xl`.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  src/libxl/libxl_conf.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

This patch looks good and could nearly be committed independent of 1/2, but I'm
afraid "PVH" in the commit message could trick people into thinking the driver
supports creating pvh domains :-).

Regards,
Jim

>
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index aa06586..155934c 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -494,11 +494,6 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
>                  }
>              }
>          }
> -
> -        /* Allow libxl to calculate shadow memory requirements */
> -        b_info->shadow_memkb =
> -            libxl_get_required_shadow_memory(b_info->max_memkb,
> -                                             b_info->max_vcpus);
>      } else {
>          /*
>           * For compatibility with the legacy xen toolstack, default to pygrub
> @@ -528,6 +523,11 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
>              return -1;
>      }
>  
> +    /* Allow libxl to calculate shadow memory requirements */
> +    b_info->shadow_memkb =
> +        libxl_get_required_shadow_memory(b_info->max_memkb,
> +                                         b_info->max_vcpus);
> +
>      return 0;
>  }
>  

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]