On Fri, Sep 16, 2016 at 12:50:38PM +0200, Erik Skultety wrote:
Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx> --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Is there a use-case for a command without info? I think all the commands should have a description and we should enforce that in the test suite.
diff --git a/tools/vsh.c b/tools/vsh.c index 4ee472c..3772d92 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -695,7 +695,7 @@ vshCmddefHelp(vshControl *ctl, const char *cmdname) } fputc('\n', stdout); - if (desc[0]) { + if (desc && *desc) {
Or maybe report an error here if the description is missing? Jan
/* Print the description only if it's not empty. */ fputs(_("\n DESCRIPTION\n"), stdout); fprintf(stdout, " %s\n", _(desc)); -- 2.5.5 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list