On Tue, Aug 30, 2016 at 17:52:24 -0400, John Ferlan wrote: ... > > + case VIR_CPU_FEATURE_DISABLE: > > + case VIR_CPU_FEATURE_FORBID: > > + x86DataSubtract(&model->data, &feature->data); > > + break; > > + > > + case VIR_CPU_FEATURE_OPTIONAL: > > [1] > Coverity happlily points out that OPTIONAL is a DEAD_CODE path > especially due to the prior check and continue; > > I see no other sane way around it other than a comment before the case: > > /* coverity[dead_error_condition] */ > case VIR_CPU_FEATURE_OPTIONAL: Easy enough. Fixed. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list