Re: [PATCH] qemu_driver: protect existed save image

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 18, 2016 at 19:47:29 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@xxxxxxxxx>
> 
> We may overwrite existed save image by
> 'virsh save' command.
> 
> This patch will check qemu save headers
> before trying to rewrite it.

I think overwriting a file is a valid use case.

If we'd want to fix it we should forbid overwriting ANY files not just
existing files created by libvirt.

NACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]