[PATCH RFC 4/5] remove unused virDomainUSBAddressRelease

[Tomasz Flendrich <t.flendrich@xxxxxxxxx>]

We no longer cache address sets, so there's no use of a function that
releases addresses.
---
 src/conf/domain_addr.c   | 30 ------------------------------
 src/conf/domain_addr.h   |  5 -----
 src/libvirt_private.syms |  1 -
 3 files changed, 36 deletions(-)

diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index c1b5580..7918781 100644
--- a/src/conf/domain_addr.c
+++ b/src/conf/domain_addr.c
@@ -1822,33 +1822,3 @@ virDomainUSBAddressEnsure(virDomainUSBAddressSetPtr addrs,
 
     return 0;
 }
-
-
-int
-virDomainUSBAddressRelease(virDomainUSBAddressSetPtr addrs,
-                           virDomainDeviceInfoPtr info)
-{
-    virDomainUSBAddressHubPtr targetHub = NULL;
-    char *portStr = NULL;
-    int targetPort;
-    int ret = -1;
-
-    if (info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB ||
-        !virDomainUSBAddressPortIsValid(info->addr.usb.port))
-        return 0;
-
-    portStr = virDomainUSBAddressPortFormat(info->addr.usb.port);
-    VIR_DEBUG("Releasing USB addr bus=%u port=%s", info->addr.usb.bus, portStr);
-
-    if (!(targetHub = virDomainUSBAddressFindPort(addrs, info, &targetPort,
-                                                  portStr)))
-        goto cleanup;
-
-    ignore_value(virBitmapClearBit(targetHub->portmap, targetPort));
-
-    ret = 0;
-
- cleanup:
-    VIR_FREE(portStr);
-    return ret;
-}
diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
index 596cd4c..15b45eb 100644
--- a/src/conf/domain_addr.h
+++ b/src/conf/domain_addr.h
@@ -304,9 +304,4 @@ int
 virDomainUSBAddressEnsure(virDomainUSBAddressSetPtr addrs,
                           virDomainDeviceInfoPtr info)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
-
-int
-virDomainUSBAddressRelease(virDomainUSBAddressSetPtr addrs,
-                           virDomainDeviceInfoPtr info)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
 #endif /* __DOMAIN_ADDR_H__ */
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index a32ce1c..59febbe 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -113,7 +113,6 @@ virDomainUSBAddressEnsure;
 virDomainUSBAddressPortFormat;
 virDomainUSBAddressPortFormatBuf;
 virDomainUSBAddressPortIsValid;
-virDomainUSBAddressRelease;
 virDomainUSBAddressReserve;
 virDomainUSBAddressSetAddControllers;
 virDomainUSBAddressSetAddHub;
-- 
1.9.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list