On Sun, Aug 14, 2016 at 04:14:54AM +0200, Tomasz Flendrich wrote:
With a parameter, we can decide whether we want qemuDomainValidateDevicePCISlotsChipsets to assign new addresses, or simply verify the existing ones and reserve slots for potential future devices. The PCI address set will be recalculated instead of being cached, and during recalculation we want to forbid assignment of new addresses.
It looks like the new parameter just errors out if address that needs to be assigned is not... It might seem better to just assign the address then. It is explicitly saying that the part of the code *should not* get executed. If that helps in future patches, I'm not totally against it, but add more information in the error message so that in case the error occurs, we know where it came from. Martin
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list