On 25.07.2016 22:48, Eric Farman wrote:
> Validate an XML schema that contains the vhost protocol in its
> hostdev tag.
>
> Signed-off-by: Eric Farman <farman@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Bjoern Walk <bwalk@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx>
> ---
> docs/schemas/domaincommon.rng | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 741f268..5c691dc 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -3991,6 +3991,18 @@
> </optional>
> </interleave>
> </group>
> + <group> <!-- vhost_scsi adapter -->
> + <attribute name="protocol">
> + <choice>
> + <value>vhost</value> <!-- vhost, required -->
> + </choice>
> + </attribute>
> + <attribute name="wwpn">
> + <data type="string">
> + <param name="pattern">(naa\.)[0-9a-fA-F]{16}</param>
> + </data>
> + </attribute>
> + </group>
> </choice>
> </element>
> </define>
>
AAh, this is the change I was missing in 06/19. Squash it there please.
The reasoning behind is to make life easier for downstream maintainers
It's very easy to forget to backport one patch - and now that we have
schema validation enabled before actually parsing the XML downstream
packages might be broken.
Moreover, it is okay if the feature can be configured in domain XML but
yet is declined on driver level.
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list