Re: [PATCH] docs: Distribute subsite.xsl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08.08.2016 12:40, Martin Kletzander wrote:
> On Mon, Aug 08, 2016 at 11:50:52AM +0200, Michal Privoznik wrote:
>> So, I've ran into very interesting problem lately. When doing the
>> following, I've encountered an error:
>>
>>  libvirt.git $ make dist && tar -xJf libvirt-2.2.0.tar.xz && \
>>                cd libvirt-2.2.0 && ./configure && \
>>                rm docs/formatdomain.html && make -C docs
>>
>>  make: Entering directory 'docs'
>>  make: *** No rule to make target 'formatdomain.html', needed by
>> 'web'.  Stop.
>>  make: Leaving directory 'docs'
>>
>> I had no idea what was going on, so I've nailed down the commit
>> that "broke it" via running git-bisect. It was this one:
>> 7659bd9221b9dd1cdf. But that shed no more light until I realized
>> that the commit might actually just exposed a problem we had. And
>> guess what - I've nailed it down. Of course we are not
>> distributing subsite.xsl that's why make prints error message.
>> Very misleading one I must say.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
>> ---
>> docs/Makefile.am | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK, almost a build-breaker-fixer

Thank you. Yeah I've could just pushed the patch. But given our history
with breaking docs/ build I rather waited for ACK.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]