On Wed, May 06, 2009 at 04:39:05PM +0100, Mark McLoughlin wrote: > This change: > > Tue Mar 3 08:55:13 GMT 2009 Daniel P. Berrange <berrange@xxxxxxxxxx> > > Don't try to detach & reset PCI devices while running test > suite for XML-> ARGV conversion. > * src/qemu_driver.c: Add qemuPrepareHostDevices() helper to > detach and reset PCI devices. > * src/qemu_conf.c: Don't detach & reset PCI devices while > building the command line argv > > accidentally did this: > > - if (hostdev->managed) { > + if (!hostdev->managed) { > > Which results in managed='yes' not causing the device to be > detached when the guest is starting. ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list