Re: [PATCH] storage: Don't remove the pool for buildPool failure in storagePoolCreate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 04, 2016 at 03:38:25PM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1362349
> 
> When adding the ability to build the pool during the start pool processing
> using the similar flags as buildPool processing would use, the code was
> essentially cut-n-pasted from storagePoolCreateXML.  However, that included
> a call to virStoragePoolObjRemove which shouldn't happen within the
> storagePoolCreate path since that'll remove the pool from the list of
> pools only to be rediscovered if libvirtd restarts.
> 
> So on failure, just fail and return as we should expect
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---

ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]