Re: [PATCH 6/9] tests: qemuxml2xml: Use DO_TEST() for most tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 29, 2016 at 07:46:26PM +0200, Andrea Bolognani wrote:
Now that DO_TEST() can be passed capabilities, there is little
need to use DO_TEST_FULL() instead of DO_TEST().
---
tests/qemuxml2xmltest.c | 353 ++++++++++++++++++++++--------------------------
1 file changed, 158 insertions(+), 195 deletions(-)


@@ -655,152 +642,129 @@ mymain(void)
    DO_TEST("metadata", NONE);
    DO_TEST("metadata-duplicate", NONE);

-    DO_TEST_FULL("pci-bridge", WHEN_BOTH, GIC_NONE,
-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
-    DO_TEST_FULL("pci-bridge-many-disks", WHEN_BOTH, GIC_NONE,
-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
-    DO_TEST_FULL("pci-autoadd-addr", WHEN_BOTH, GIC_NONE,
-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
-    DO_TEST_FULL("pci-autoadd-idx", WHEN_BOTH, GIC_NONE,
-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
+    DO_TEST("pci-bridge",
+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
+    DO_TEST("pci-bridge-many-disks",
+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
+    DO_TEST("pci-autoadd-addr",
+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
+    DO_TEST("pci-autoadd-idx",
+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
    DO_TEST("pci-autofill-addr", NONE);


Now you can fit some of the tests on a single line.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]