Re: [PATCH 3/9] tests: qemuxml2xml: Fix disk-mirror

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It's not really broken.

Maybe s/Fix/clean up/?

On Fri, Jul 29, 2016 at 07:46:23PM +0200, Andrea Bolognani wrote:
Instead of testing it twice using WHEN_ACTIVE and WHEN_INACTIVE
separately, just use WHEN_BOTH.
---
tests/qemuxml2xmltest.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 5f04b8b..2af8245 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -477,8 +477,7 @@ mymain(void)
                 QEMU_CAPS_SCSI_MPTSAS1068,
                 QEMU_CAPS_SCSI_DISK_WWN);
    DO_TEST("disk-mirror-old");
-    DO_TEST_FULL("disk-mirror", WHEN_ACTIVE, GIC_NONE, NONE);
-    DO_TEST_FULL("disk-mirror", WHEN_INACTIVE, GIC_NONE, NONE);
+    DO_TEST_FULL("disk-mirror", WHEN_BOTH, GIC_NONE, NONE);
    DO_TEST_FULL("disk-active-commit", WHEN_ACTIVE, GIC_NONE, NONE);
    DO_TEST("graphics-listen-network");
    DO_TEST("graphics-vnc");
--
2.7.4

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]