On 08/03/2016 03:51 AM, Joao Martins wrote: > On 08/03/2016 12:49 AM, Jim Fehlig wrote: >> Long, long ago before libxl_get_required_shadow_memory() was >> made publicly available, its code was copied to the libxl driver >> for calculating shadow memory requirements of HVM domains. >> >> Long ago, libxl_get_required_shadow_memory() was exported in >> libxl_utils.h and included in xen-devel packages everywhere. >> >> Remove the copied code, which has become stale, and let libxl >> provode a proper shadow memory value. >> >> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> >> --- >> >> I ensured libxl_get_required_shadow_memory() was available >> as far back as Xen 4.4, which is the minimum version supported >> by the libxl driver. > Cool, and FWIW, Looks good to me: > > Acked-by: Joao Martins <joao.m.martins@xxxxxxxxxx> Thanks. It's an obvious improvement that should have been done long ago. > > (Also tested an HVM guest in which codepath goes through): Same here. And I ensured the calculation was the same compared to a VM started with xl. I've pushed the patch. Regards, Jim -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list