Re: [PATCHv3 2a/9] qemu: Remove generation of drive alias from qcow passphrase backends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 01, 2016 at 08:23:37AM -0400, John Ferlan wrote:
Rather than pass the disks[i]->info.alias to qemuMonitorSetDrivePassphrase
and then generate the "drive-%s" alias from that, let's use qemuAliasFromDisk
prior to the call to generate the drive alias and then pass that along
thus removing the need to generate the alias from the monitor code.

Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
---

Mainly so it's more apparent/transparent what I was planning to do.
If you'd rather see the whole series again - that's not a problem...

src/qemu/qemu_monitor_json.c | 7 +------
src/qemu/qemu_monitor_text.c | 3 +--
src/qemu/qemu_process.c      | 2 +-
tests/qemumonitorjsontest.c  | 2 +-
4 files changed, 4 insertions(+), 10 deletions(-)


ACK

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]