On Mon, Aug 01, 2016 at 06:21:49PM +0200, Michal Privoznik wrote:
There's no point in forcing some functions to be both 'static' and 'inline' at the same time at the header file level. This leads to a situation where just linking the file defines those function (potentially needlessly). Instead, we should let the compiler (linker) decide whether the function are small enough to be inlined or not.
If I understand it correctly, these will not get inlined after your change at all because they will be assembled only in that device_conf.c. If you wanted to make the compiler decide, you'd need to keep it in the header file and just remove the inline keyword. But I'm not basing this on anything more than my common sense, so if I'm wrong, feel free to correct me with some facts =)
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list