Hi, > ... Gerd's above metadata change is dated 2016-03-21, at which point > both QEMU v2.4.0 and v2.5.0 had been tagged (on 2015-08-11 and on > 2015-12-16, respectively). I guess Gerd may have mis-remembered the > exact QEMU release which included SMM support? Either that, or because some of the bits needed for secure boot didn't made it into 2.4 (and secure boot being *the* use case for smm emulation). > ... Anyway, looking over your patch quickly, I think it really only > concerns itself with "-machine smm=on", and for that, the 2.4 version > check should suffice. It's only OVMF that needs a lot more than that. Well, in kvm mode there is also a kernel support for smm required ... cheers, Gerd -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list