Re: [PATCH python 1/2] Python binding for node poll lifecycle events API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/28/2016 08:14 AM, Jovanka Gulicoska wrote:
> ---
>  generator.py                   |   2 +
>  libvirt-override-virConnect.py |  45 ++++++++++++
>  libvirt-override.c             | 153 +++++++++++++++++++++++++++++++++++++++++
>  sanitytest.py                  |   3 +
>  4 files changed, 203 insertions(+)
> 
> diff --git a/generator.py b/generator.py
> index 82f13e9..730e456 100755
> --- a/generator.py
> +++ b/generator.py
> @@ -525,6 +525,8 @@ skip_function = (
>      'virConnectNetworkEventDeregisterAny', # overridden in virConnect.py
>      'virConnectStoragePoolEventRegisterAny',   # overridden in virConnect.py
>      'virConnectStoragePoolEventDeregisterAny', # overridden in virConnect.py
> +    'virConnectNodeDeviceEventRegisterAny',   # overridden in virConnect.py
> +    'virConnectNodeDeviceEventDeregisterAny', # overridden in virConnect.py
>      'virSaveLastError', # We have our own python error wrapper
>      'virFreeError', # Only needed if we use virSaveLastError
>      'virConnectListAllDomains', # overridden in virConnect.py
> diff --git a/libvirt-override-virConnect.py b/libvirt-override-virConnect.py
> index b085b07..fb3d476 100644
> --- a/libvirt-override-virConnect.py
> +++ b/libvirt-override-virConnect.py
> @@ -347,6 +347,51 @@
>          self.storagePoolEventCallbackID[ret] = opaque
>          return ret
>  
> +    def _dispatchNodeDeviceEventLifecycleCallback(self, dev, event, detail, cbData):
> +        """Dispatches events to python user node device
> +           lifecycle event callbacks
> +        """
> +        cb = cbData["cb"]
> +        opaque = cbData["opaque"]
> +
> +        cb(self, virNodeDevice(self, _obj=dev), event, detail, opaque)
> +        return 0
> +
> +    def _dispatchNodeDeviceEventGenericCallback(self, dev, cbData):
> +        """Dispatches events to python user node device
> +           generic event callbacks
> +        """
> +        cb = cbData["cb"]
> +        opaque = cbData["opaque"]
> +
> +        cb(self, virNodeDevice(self, _obj=dev), opaque)
> +        return 0
> +

The GenericCallback isn't used anywhere, so this can be dropped. I've made
that change and applied these locally, I'll push after the release.

Thanks,
Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]