Re: [gconfig v2 0/2] Add host setters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Thu, Jul 28, 2016 at 06:16:37PM +0300, Visarion Alexandru wrote:
> From: Visarion Alexandru <viorel.visarion@xxxxxxxxx>
> 
> These new patches are a bit different than the last ones.
> I first delete the <listen address=""> child node and
> then I modify the <listen> attribute.

You could mention this in the commit log of each patch as well, and
indicate that otherwise we could get inconsistencies between the listen
node and attribute, which causes errors when trying to start (or define
?) the domain.

Christophe

> 
> Visarion Alexandru (2):
>   config: Add vnc host setter
>   config: Add spice host setter
> 
>  libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++++++++++
>  libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h |  3 +++
>  libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c   |  9 +++++++++
>  libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h   |  3 +++
>  libvirt-gconfig/libvirt-gconfig.sym                     |  2 ++
>  5 files changed, 27 insertions(+)
> 
> -- 
> 2.7.4
> 
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]