On Wed, Jul 13, 2016 at 01:42:15PM +0300, Derbyshev Dmitriy wrote:
> From: Derbyshev Dmitry <dderbyshev@xxxxxxxxxxxxx>
>
> Is necessary to call it from other contexts, such as qemuDomainGetStatsBalloon.
>
> Signed-off-by: Derbyshev Dmitry <dderbyshev@xxxxxxxxxxxxx>
> ---
> src/qemu/qemu_driver.c | 55 ++++++++++++++++++++++++++++++++------------------
> 1 file changed, 35 insertions(+), 20 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index f8d9afe..6fa8d01 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -10959,32 +10959,22 @@ qemuDomainGetInterfaceParameters(virDomainPtr dom,
> return ret;
> }
>
> +/* This functions assumes that job QEMU_JOB_QUERY is started by a caller */
> +
This was already pointed out, we don't put a new line between function and a
comment for that function.
> static int
> -qemuDomainMemoryStats(virDomainPtr dom,
> - virDomainMemoryStatPtr stats,
> - unsigned int nr_stats,
> - unsigned int flags)
> +qemuDomainMemoryStatsInternal(virQEMUDriverPtr driver,
> + virDomainObjPtr vm,
> + virDomainMemoryStatPtr stats,
> + unsigned int nr_stats)
> +
> {
> - virQEMUDriverPtr driver = dom->conn->privateData;
> - virDomainObjPtr vm;
> int ret = -1;
> long rss;
>
ACK
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list