On Tue, Jul 26, 2016 at 17:21:37 +0530, Prasanna Kalever wrote:
> On Mon, Jul 25, 2016 at 11:42 PM, Peter Krempa <pkrempa@xxxxxxxxxx> wrote:
> > From: Prasanna Kumar Kalever <prasanna.kalever@xxxxxxxxxx>
> >
> > To allow using failover with gluster it's necessary to specify multiple
> > volume hosts. Add support for starting qemu with such configurations.
> >
> > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> > ---
> > docs/formatdomain.html.in | 2 +-
> > src/qemu/qemu_command.c | 102 +++++++++++++++++++++
> > .../qemuxml2argv-disk-drive-network-gluster.args | 9 +-
> > .../qemuxml2argv-disk-drive-network-gluster.xml | 9 ++
> > .../qemuxml2xmlout-disk-drive-network-gluster.xml | 10 ++
> > 5 files changed, 130 insertions(+), 2 deletions(-)
[...]
> > @@ -932,7 +1027,14 @@ qemuGetDriveSourceProps(virStorageSourcePtr src,
> > case VIR_STORAGE_TYPE_VOLUME:
> > case VIR_STORAGE_TYPE_NONE:
> > case VIR_STORAGE_TYPE_LAST:
> > + break;
> > +
> > case VIR_STORAGE_TYPE_NETWORK:
> > + if (src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER &&
> > + src->nhosts > 1) {
> > + if (!(fileprops = qemuBuildGlusterDriveJSON(src)) < 0)
>
> ouch!
> comparing boolean result with constant 0
I've fixed it on my local branch. Thanks.
>
> --
> Prasanna
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list