On 07/18/2016 12:15 PM, Ján Tomko wrote: > Patches 1-2 from v4 are pushed already. > > Patch 5/8 is new, adding new tests. > Patches 6/8 and 8/8 have not been ACKed in the previous version. > > > Ján Tomko (8): > Introduce virDomainUSBAddressSet > Add functions for adding USB controllers to addrs > Add functions for adding USB hubs to addrs > Reserve existing USB addresses > Add tests for USB address assignment > Assign addresses to USB devices > Assign addresses on USB device hotplug > Auto-add one hub if there are too many USB devices > > src/conf/domain_addr.c | 501 +++++++++++++++++++++ > src/conf/domain_addr.h | 51 +++ > src/libvirt_private.syms | 9 + > src/qemu/qemu_domain.c | 1 + > src/qemu/qemu_domain.h | 1 + > src/qemu/qemu_domain_address.c | 156 ++++++- > src/qemu/qemu_hotplug.c | 27 ++ > .../qemuhotplug-base-live+disk-usb.xml | 1 + > .../qemuxml2argvdata/qemuxml2argv-bios-nvram.args | 2 +- > tests/qemuxml2argvdata/qemuxml2argv-bios.args | 2 +- > .../qemuxml2argv-controller-order.args | 8 +- > .../qemuxml2argv-disk-usb-device-removable.args | 3 +- > .../qemuxml2argv-disk-usb-device.args | 2 +- > .../qemuxml2argv-graphics-spice-timeout.args | 2 +- > .../qemuxml2argv-graphics-spice-usb-redir.args | 2 +- > ...muxml2argv-hostdev-usb-address-device-boot.args | 3 +- > .../qemuxml2argv-hostdev-usb-address-device.args | 2 +- > .../qemuxml2argv-hostdev-usb-address.args | 2 +- > .../qemuxml2argv-hugepages-numa.args | 6 +- > .../qemuxml2argv-input-usbmouse.args | 2 +- > .../qemuxml2argv-input-usbtablet.args | 2 +- > .../qemuxml2argv-pseries-usb-kbd.args | 2 +- > .../qemuxml2argv-serial-spiceport.args | 2 +- > .../qemuxml2argv-smartcard-controller.args | 2 +- > .../qemuxml2argv-smartcard-host-certificates.args | 2 +- > .../qemuxml2argv-smartcard-host.args | 2 +- > ...emuxml2argv-smartcard-passthrough-spicevmc.args | 2 +- > .../qemuxml2argv-smartcard-passthrough-tcp.args | 2 +- > .../qemuxml2argv-sound-device.args | 2 +- > .../qemuxml2argv-usb-hub-autoadd.args | 28 ++ > .../qemuxml2argv-usb-hub-autoadd.xml | 23 + > .../qemuxml2argv-usb-hub-conflict.xml | 22 + > .../qemuxml2argv-usb-ich9-autoassign.args | 32 ++ > .../qemuxml2argv-usb-ich9-autoassign.xml | 39 ++ > .../qemuxml2argv-usb-port-autoassign.args | 28 ++ > .../qemuxml2argv-usb-port-autoassign.xml | 27 ++ > .../qemuxml2argv-usb-port-missing.args | 4 +- > .../qemuxml2argv-usb-redir-boot.args | 2 +- > tests/qemuxml2argvdata/qemuxml2argv-usb-redir.args | 2 +- > .../qemuxml2argv-usb-xhci-autoassign.args | 27 ++ > .../qemuxml2argv-usb-xhci-autoassign.xml | 25 + > tests/qemuxml2argvtest.c | 17 + > 42 files changed, 1046 insertions(+), 31 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-autoadd.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-autoadd.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-conflict.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-ich9-autoassign.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-ich9-autoassign.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-port-autoassign.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-port-autoassign.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-xhci-autoassign.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-xhci-autoassign.xml > Although I would have liked to see a bit more verbose comments/function intros, it's not something that I'd stop progress for... FWIW: w/r/t my comment in v4 patch 9 regarding qemuxml2argv-usb-hub-autoadd.xml. I too don't get an error (per se) any more... If I change the "index='0'" to be "index='1'" and add the PIIX3_USB_UHCI and PCI_MULTIFUNCTION caps for the test, I now get a different .args output. I think it's correct, but I'm sure you can have a look see with just that much information... In any case, ACK series, John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list