On Tue, 2016-07-19 at 16:30 +0100, Justin Clift wrote: > On 19 Jul 2016, at 15:03, Andrea Bolognani <abologna@xxxxxxxxxx> wrote: > <snip> > > > > > > > > It's outside the #endif for __VIR_SYSTEMD_H___ though, so I'm kind of > > > thinking it would need to be move inside the guard (which also compiles > > > ok), or is there a better place/file for it instead? :) > > > > I have posted a tentative patch to fix your issue > > > > https://www.redhat.com/archives/libvir-list/2016-July/msg00724.html > > > > Can you please check it out and confirm whether it works or > > not? I don't have any OS X host where I can test it myself. > > > > To be honest, I don't see why we're compiling the systemd > > support code on OS X at all. But I don't have the time to > > dig further right now :) > > Oops, it didn't click for me that this is systemd code. You're right, > there's no need for that to be compiled on OSX. :) > > Looking at the output from ./configure, there doesn't seem to be a > switch for disabling systemd stuff. > > Did I overlook something? :) You didn't overlook anything: there's simply no way to compile the systemd support conditionally, at least at the moment :) Did you manage to build and run libvirt succesfully with the patch I posted? -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list