Re: [PATCH 3/4] hvsupport: construct regex up front

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/29/2016 02:40 AM, Ján Tomko wrote:
> This lets perl cache the regex.
> 
> Even though there are only eight groups, the speedup is more than that.

eight groups?  I'm glad someone knows what they are...

> ---
>  docs/hvsupport.pl | 33 ++++++++++++++++-----------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
> 

Again - this seems to work for the current good environment. Although I
can confess I didn't try to add a dummy API and ensure that it got
flagged. I assume you've done that...

Another weak ACK,

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]