[PATCH 0/2] Error out on unsupported formats for vol-wipe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Historically, vol-wipe was created to rewrite volume with either zeros
or some algorithm.  However for non-raw file-based images rewriting or
erasing and recreating them destroys their format.  The solution
seemed easy -- just delete and rebuild the volume.  However we don't
store the flags used during creation so we can't safely ensure that
the new volume will be the same as the original one.  Moreover since
commit eec91958b4b0abdbb7ab769f540bcfa72a107c9b we document that it's
probably not what users are trying to do.  Instead of screwing up the
format, let's just disable all the formats that are not supported now.


Martin Kletzander (2):
  storage: Don't delete Ploop volumes twice
  storage: Forbid wiping formatted volume types that are not supported

 src/storage/storage_backend.c | 59 +++++++++++++++++++++++++++----------------
 1 file changed, 37 insertions(+), 22 deletions(-)

--
2.9.0

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]