On Thu, Apr 30, 2009 at 02:16:35PM +0200, Ludwig Nussel wrote:
> Bridges that are not up won't forward packets
Ah yes, good point :-)
Daniel
> ---
> src/network_driver.c | 9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/src/network_driver.c b/src/network_driver.c
> index a17a769..a163b15 100644
> --- a/src/network_driver.c
> +++ b/src/network_driver.c
> @@ -836,8 +836,7 @@ static int networkStartNetworkDaemon(virConnectPtr conn,
> goto err_delbr;
> }
>
> - if (network->def->ipAddress &&
> - (err = brSetInterfaceUp(driver->brctl, network->def->bridge, 1))) {
> + if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 1))) {
> virReportSystemError(conn, err,
> _("failed to bring the bridge '%s' up"),
> network->def->bridge);
> @@ -878,8 +877,7 @@ static int networkStartNetworkDaemon(virConnectPtr conn,
> networkRemoveIptablesRules(driver, network);
>
> err_delbr1:
> - if (network->def->ipAddress &&
> - (err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) {
> + if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) {
> char ebuf[1024];
> networkLog(NETWORK_WARN, _("Failed to bring down bridge '%s' : %s\n"),
> network->def->bridge, virStrerror(err, ebuf, sizeof ebuf));
> @@ -920,8 +918,7 @@ static int networkShutdownNetworkDaemon(virConnectPtr conn,
> networkRemoveIptablesRules(driver, network);
>
> char ebuf[1024];
> - if (network->def->ipAddress &&
> - (err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) {
> + if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) {
> networkLog(NETWORK_WARN, _("Failed to bring down bridge '%s' : %s\n"),
> network->def->bridge, virStrerror(err, ebuf, sizeof ebuf));
> }
> --
> 1.6.2.1
>
> --
> Libvir-list mailing list
> Libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list